EldinZenderink / SimpleIRCLib

A lightweight, simple to use and implement, IRC library with support for DCC download (no upload)
MIT License
14 stars 14 forks source link

DCC when using the form example #3

Closed Og1Kenobi closed 7 years ago

Og1Kenobi commented 8 years ago

When sending a file to this client via DCC it will consistently fail at 95% according to this clients debug. The sending client show a successful send.

EldinZenderink commented 8 years ago

And the file? Was the file correctly downloaded?

Og1Kenobi commented 8 years ago

Using mIRC it shows transfer complete. simpleirc debug says :+1:

New Filename: plot.log

newFileName(without illigal chars): plot.log

New Filename: plot.log

newIpBW: 167772179

DCC SERVER REPLY: :jdouglas!jdouglas@iWedge.verticalliquid.com PRIVMSG MrTester :DCC SEND plot.log 167772179 1024 537

FILENAME: plot.log

FILESIZE: 537

IP: 10.0.0.19

PORT: 1024

PACK: File does not exist yet, start connection

BOT: Download stopped at < 95 % finished, deleting file: plot.log

File has been downloaded! File Location:C:\Users\Jonathan\Documents\Visual Studio 2015\Projects\SimpleIRCLib-master\FormExample\bin\Debug\plot.log

This happens even if i change the download directory etc

EldinZenderink commented 8 years ago

Ok, that is probably my fault, I only tested this library with big files, forgot about the small stuff, my apologie, will try to fix this as soon as possible as well

Og1Kenobi commented 8 years ago

No worries.

Sent from my iPhone

On Apr 24, 2016, at 10:58 AM, Eldin Zenderink notifications@github.com wrote:

Ok, that is probably my fault, I only tested this library with big files, forgot about the small stuff, my apologie, will try to fix this as soon as possible as well

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub

EldinZenderink commented 8 years ago

The dcc problem for downloading small files has been fixed, atleast it appears to work on my end. Please tell me your findings so that we can close these issues!

Og1Kenobi commented 8 years ago

irc1 irc2

EldinZenderink commented 8 years ago

Hmmm, weird, must be a really reaaally tiny file you are sending their... ok, will try to sort it out, i will close the other issue :D, sorry for asking this much, but unfortunately the debug form is scrolled all the way up in your screenshot (me stupid for just noticing), could you try again and scroll down in the debug window? Atleast until you see a message that goes something like this:

Something went wrong while downloading the file! Removing from xdcc que to be sure! Error:

This message will appear after starting a dcc download, when it fails to download. That message is hopefully going to tell me about the issue at hand. Without it, I can only guess.

Edit: I might not come around to fixing this issue this evening, I will not be able to respond quickly either. If do get to fixing it, it will be late in the evening unfortunately.