search

Eleanorsoft / magento-dicompile

Speed up Magento2 DI compilation
13 stars 2 forks source link

Compatibility with 2.2.3 #1

Open fabrice-dresscodes opened 4 years ago

fabrice-dresscodes commented 4 years ago

Hello,

I was wondering if your extension is compatible with 2.2.3.

On fresh install, when I compile your module, I got this error :

php bin/magento setup:di:compile PHP Fatal error: Uncaught Error: Cannot instantiate interface Magento\Setup\Module\Di\Compiler\Config\WriterInterface in ..../vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:50 Stack trace:

0 ..../vendor/magento/framework/ObjectManager/ObjectManager.php(70): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\Setup\M...')

1 ..../vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(160): Magento\Framework\ObjectManager\ObjectManager->get('Magento\Setup\M...')

2 ..../vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(246): Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument(Array, 'Magento\Setup\M...', NULL, 'configWriter', 'Eleanorsoft\DiC...')

3 ..../vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(34): Magento\Framework\ObjectManager\Factory\AbstractFact in ..../vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php on line 50

kostofffan commented 4 years ago

Hi,

Does it compile without our module?

(Tested on 2.2.4 and it worked)

fabrice-dresscodes commented 4 years ago

Yes for sure because I'm developping module for my client;

Le 21/11/2019 à 10:26, Konstantin Esin a écrit :

Hi,

Does it compile without our module?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Eleanorsoft/magento-dicompile/issues/1?email_source=notifications&email_token=ACIC74YVRT42LJPNNQA2DZDQUZH5XA5CNFSM4JPT4P52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZRM3I#issuecomment-556996205, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACIC743HTLEBL7WDNUPOGJLQUZH5XANCNFSM4JPT4P5Q.

--

*

      Fabrice Bourgeon

Certification Magento Retrouvez nous sur les réseaux sociaux Page Facebook de l'agence Dresscodes https://www.facebook.com/agencedresscodes/

marvinhinz commented 4 years ago

In magento 2.3.3 the used WriterInterface is deprecated. This should be used in Area.php:59:

\Magento\Framework\App\ObjectManager\ConfigWriter\Filesystem $configWriter

mariusjp commented 4 years ago

In magento 2.3.3 the used WriterInterface is deprecated. This should be used in Area.php:59:

\Magento\Framework\App\ObjectManager\ConfigWriter\Filesystem $configWriter

This did indeed made it work in 2.3.3! That being said, I barely see any reduction of compilation time

It did NOT work after that change after some thorough testing and even breaks it completely