Elecs-Mods / CraftingTable-IV

CraftingTable IV mod, the successor of the CraftingTable III mod from MC1.2.5
12 stars 4 forks source link

Exploit: Recipe search ignores NBT constraints. #74

Closed AnrDaemon closed 5 years ago

AnrDaemon commented 6 years ago

Discovered in 1.7.10 CraftTweaker+ModTweaker+Thaumcraft+CraftingTable IV.

recipes.addShapeless(<Thaumcraft:ItemResource:15>, [<Thaumcraft:WandCasting:*>.onlyWithTag({sceptre: 1})]);

Craft a simple wooden wand with iron caps. Talk to Crafting Table IV. Craft Primal Charm from a wand that never had it.

Elec332 commented 6 years ago

1.7.10 is very old and not supported anymore, but if I fire the 1.7.10 dev env up Ill take a look

AnrDaemon commented 6 years ago

I'm not so familiar with newer versions, but I hope you could check the issue yourself, given easy enough reproduction steps. Something as easy as

recipes.addShapeless(<minecraft:diamond_block>, [<ore:ingotIron>.onlyWithTag({hiddenDiamonds: 1})]);

should work.

Elec332 commented 5 years ago

The newest versions should have checks for NBT