search

Electa-Git / StochasticPowerModels.jl

An extension package of PowerModels.jl for Stochastic Power System Optimization
BSD 3-Clause "New" or "Revised" License
16 stars 7 forks source link

PSCC Paper: case study benchmark with Mülphfordt paper #15

Closed timmyfaraday closed 3 years ago

timmyfaraday commented 3 years ago

@timueh - for your review, very much appreciate the help!

codecov[bot] commented 3 years ago

Codecov Report

Merging #15 (ffc1844) into master (e3e2738) will decrease coverage by 0.13%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   74.07%   73.94%   -0.14%     
==========================================
  Files          13       13              
  Lines         949      948       -1     
==========================================
- Hits          703      701       -2     
- Misses        246      247       +1
Impacted Files Coverage Δ
src/prob/sopf_iv_itr.jl 94.96% <0.00%> (-0.72%) :arrow_down:
src/StochasticPowerModels.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3e2738...ffc1844. Read the comment docs.

timueh commented 3 years ago

Looks fine to me, semantically!

Except for the Julia 1.5 tests?.

timmyfaraday commented 3 years ago

Hi @timueh,

We have done some spring cleaning following the submission of our PSCC paper and will revisit this first thing! During the spring cleaning, we have addressed the issue you posed in the previous comment!

Tom