Closed keithrfung closed 2 years ago
Can i work on this if its alright?
@pratik2315 It's all yours.
hey @keithrfung ! I have done the changes and put the comment in electionguard_tools/helpers/init.py. I've put the comment in init.py file. pls suggest any changes if required. thanks.
@pratik2315 The concern is the entire class needs to be relocated not just the comment (docstring).
Tasks
election_builder.py
ElectionBuilder
to this new filemake auto-lint
make test
Oh my bad, I should've asked more questions, I'll make the change and migrate the entire class under helpers.
Hey can you help me out im recieving some errors while running the tests and im unable to figure out exactly what are they
You may have to alter the file paths for windows. We recommend running this in WSL2.
Is there an existing issue for this?
Suggestion
The
ElectionBuilder
is a stateful factory to create an election. This should be migrated toelectionguard_tools
under helpers. The existing references toElectionBuilder
should be updated. Be sure to make sure toauto-lint
to have the init's updated.Location of
ElectionBuilder
https://github.com/microsoft/electionguard-python/blob/8aa589c9744bdf52e1e2659e2f83c255ffc65441/src/electionguard/election_builder.py#L13-L18Possible Implementation
No response
Anything else?
No response