ElectionDataAnalysis / electiondata

Tools for consolidation and analysis of raw election results from the most reliable sources -- the election agencies themselves.
Other
20 stars 5 forks source link

Version 2.0.0 #709

Closed sfsinger19103 closed 2 years ago

sfsinger19103 commented 3 years ago

Release notes per CII: The project MUST provide, in each release, release notes that are a human-readable summary of major changes in that release to help users determine if they should upgrade and what the upgrade impact will be. The release notes MUST NOT be the raw output of a version control log (e.g., the "git log" command results are not release notes). Projects whose results are not intended for reuse in multiple locations (such as the software for a single website or service) AND employ continuous delivery MAY select "N/A". (URL required)

Testing policy, per CII: The project MUST have evidence that the test_policy for adding tests has been adhered to in the most recent major changes to the software produced by the project. [tests_are_added] Hide details Major functionality would typically be mentioned in the release notes. Perfection is not required, merely evidence that tests are typically being added in practice to the automated test suite when new major functionality is added to the software produced by the project.

sfsinger19103 commented 3 years ago

Warning to be fixed:

/usr/local/lib/python3.9/site-packages/electiondata-2.0-py3.9.egg/electiondata/database/init.py:2330: SADeprecationWarning: A column with name 'Election_Id' is already present in table 'ElectionExternalDataSetJoin'. Please use method :meth:_schema.Table.append_column with the parameter replace_existing=True to replace an existing column. t = Table(

sfsinger19103 commented 2 years ago

PerformanceWarning thrown by this code can be fixed by using melted = pd.concat([melted, <the right df>], axis=1):

            melted[
                [f"count_header_{idx}" for idx in p["count_header_row_numbers"]]
            ] = pd.DataFrame(melted["header_0"].str.split(";:;", expand=True).values)[
                [tab_to_df[idx] for idx in p["count_header_row_numbers"]]
            ]
sfsinger19103 commented 2 years ago

Not all warnings resolved; closing this issue anyway.