Electric-Coin-Company / tfl-book

A Trailing Finality Layer book for a proposed Zcash protocol change.
MIT License
5 stars 2 forks source link

Dependency caching may be missing on every PR. #34

Open nathan-at-least opened 1 year ago

nathan-at-least commented 1 year ago

What is the problem?

I'm not fully certain, but it may be that caching of dependencies is missing on every PR (thus preventing any benefit from caching). This makes PR and rendering CI slower, if true.

Do you recommend a solution?

First investigate if we can remove any cache key scoping based on branch.

In fact, cache scope should be very stable for dependencies, only needing to be invalidated/missed when there are newer tool releases (and even then, only if we care). Maybe the "empty key" is the simplest solution, if it exists?