search

Electric-Coin-Company / zashi-android

The Zashi Zcash Wallet, Android Edition
MIT License
20 stars 14 forks source link

ISSUE-1412 Receive Page split into horizontal pager #1462

Closed Milan-Nerevar closed 2 weeks ago

Milan-Nerevar commented 4 weeks ago

Snímka obrazovky 2024-06-04 o 17 56 36

The design is not 100% pixel perfect because didnt have time, but I guess its quite enough for a demo. Also scroll is not broken because i disabled the horizontal pager one so u can still swipe between bottom pages.

Milan-Nerevar commented 3 weeks ago

Thank you for the changes. It's very appreciated! I left some comments inline and a few notes here below:

  1. You seem to have different AS editor settings that caused several unnecessary changes in indentation.
  2. Although it's not perfectly visible at first look, I think we need to revert the UI logic so that the selected tab has a white button state and the second one has only black surrounding it.
  3. I've tried the proposed changes on a split-screen device to emulate a very small screen, and the address tabs do not seem to be vertically scrollable anymore. You can also test by rotating the device to landscape, which is supported in the debug build type.
  4. I've approved the changes for the CI run, and it reported some issues.
  1. Yes, editor settings can be shared by project in .idea so that this does not happen -> improvement :)
  2. It's possible, I was not sure which one is which from the design :D
  3. I forgot vertical scroll modifier :) 1 line code change
  4. After first points is fixed CI should go through I guess
Milan-Nerevar commented 3 weeks ago

@HonzaR whats the next coarse of action? Should I fix up the PR or?

HonzaR commented 3 weeks ago

@HonzaR whats the next coarse of action? Should I fix up the PR or?

Yes, let's update the PR to resolve the review comments, if you like? Make sure to fix the CI actions reports. I'll approve the CI run for you then. Thank you.

Milan-Nerevar commented 3 weeks ago

@HonzaR u can recheck, but probably lint will fail - even tho I am using project code style

HonzaR commented 2 weeks ago

@HonzaR u can recheck, but probably lint will fail - even tho I am using project code style

Hi @Milan-Nerevar, Thank you for the update commits! The static code analysis checks are still failing. It's a good approach to check your changes locally before pushing. See the predefined Gradle tasks in our Setup documentation. Would you like to fix those too?