Electric-Coin-Company / zashi-android

The Zashi Zcash Wallet, Android Edition
MIT License
22 stars 15 forks source link

[#1492] Restore success dialog refactor #1507

Closed Milan-Cerovsky closed 2 months ago

Milan-Cerovsky commented 2 months ago
Previews App
Snímka obrazovky 2024-07-08 o 16 37 39 Screenshot_20240708_163835

Closes #1492

Reviewer

[^1]: Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs. [^2]: While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down. [^3]: _While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules._ [^4]: Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit. [^5]: In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass. [^6]: While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

HonzaR commented 2 months ago

Before approaching to review these changes, we agreed on splitting up the new RestoreSuccessView from HomeView and its package into a dedicated package, e.g. restoresuccess.