Electric-Coin-Company / zashi-android

The Zashi Zcash Wallet, Android Edition
MIT License
27 stars 15 forks source link

Encode URI in QR Code #168

Open ccjernigan opened 2 years ago

ccjernigan commented 2 years ago

The QR code on the address screen contains the naked UA address string, when it should contain a URI.

See https://zips.z.cash/zip-0316 https://zips.z.cash/zip-0321

pacu commented 2 years ago

I think there's a mixup here.

The screens showing addresses should contain addresses only. URIs are used in the case of requesting ZEC for a specific amount.

ccjernigan commented 2 years ago

The problem I'd like to solve is users who might scan a QR code using another app, like the Camera app. They'll end up with a bad experience because the Camera won't know what to do with the naked address. By embedding a URI in the QR code, we should be able to link into the app if users try alternative QR code scanners.

Some Zcash wallets are presenting naked addresses in their QR codes, so we need a way to at least partially have a migration path to this new convention.

An implementation proposal for moving forward: