Send tests were done for a single reducer that handled both send and confirmation scenarios. Confirmation has been refactored into a standalone reducer so now the logic consists of 2 independent reducers.
The goal:
instead of fixing the tests, a new set of tests is needed to be implemented to cover the same functionality + new functionality
example:
Very first test testSendSucceeded() is supposed to check whether flag is set and proper sendDone action is called afterwards. This logic has been moved to Confirmation reducer but send has something similar, instead of sending, it's reviewing and getting the proposal, opening confirmation is the success of this operation and should be checked.
LukasKorba
commented
3 months ago
Send tests were done for a single reducer that handled both send and confirmation scenarios. Confirmation has been refactored into a standalone reducer so now the logic consists of 2 independent reducers.
The goal:
example: Very first test
testSendSucceeded()is supposed to check whether flag is set and proper sendDone action is called afterwards. This logic has been moved to Confirmation reducer but send has something similar, instead of sending, it's reviewing and getting the proposal, opening confirmation is the success of this operation and should be checked.