search

Electric-Coin-Company / zashi-ios

The Zashi Zcash Wallet, iOS Edition
MIT License
38 stars 12 forks source link

Re-enable support for using Zashi on Apple Silicon macs #877

Open daira opened 1 year ago

daira commented 1 year ago

This was disabled in Appstore Connect because additional work is required to make input work correctly. Note that LSMinimumSystemVersion will also need to be set to 13.0.

zookozcash commented 1 year ago

Whether we are going to re-enable support for Zashi on Mac or not remains to be decided. Next step: Dir/Eng (currently me) talks to str4d.

daira commented 2 months ago

This was disabled in Appstore Connect because additional work is required to make input work correctly.

I believe this was #1013, for which I've suggested a workaround:

Assuming it is actually caused by autocomplete / "inline predictive text", a user can probably work around it by turning that off globally. That said, it's obviously still a bug in the app, relative to other macOS apps.

Another possibility is to have the app turn off autocomplete for all fields that it affects:

textField.autocorrectionType = .no
textField.spellCheckingType = .no

This could be done conditionally if the app is running on macOS:

The isiOSAppOnMac property of ProcessInfo tells you whether your iOS app is running in macOS or iOS, but checking that property should always be your last choice. It’s better to run the same code on both platforms.

daira commented 2 months ago

It's up to @true-jared and @LukasKorba to decide whether to reprioritize this. (Just clarifying that Zooko's comment is obsolete.)