Electric-Coin-Company / zcash-android-wallet-sdk

Native Android SDK for Zcash
MIT License
5 stars 7 forks source link

[#1236] Add ability to restore wallet from seed phrase and birthday #1487

Closed thats-bot closed 3 weeks ago

thats-bot commented 1 month ago

Add ability to restore wallet from seed phrase and birthday on demo-app first start.

image

Note This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

Reviewer

[^1]: Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs. [^2]: While we aim for automated testing of the SDK, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down. [^3]: _While we are not looking for perfect coverage, the tool can point out potential cases that have been missed. Code coverage can be generated with: ./gradlew check for Kotlin modules and ./gradlew connectedCheck -PIS_ANDROID_INSTRUMENTATION_TEST_COVERAGE_ENABLED=true for Android modules._ [^4]: Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit. [^5]: In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass. [^6]: While the CI server runs the demo app to look for build failures or crashes, humans running the demo app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

HonzaR commented 1 month ago

Unfortunately, I'm unable to build and test the changes, possibly due to #1494, which we're analyzing. So, let's wait with merging the changes.

This is resolved now. It was a setup problem in my environment.

thats-bot commented 1 month ago

@HonzaR it is a setup issue on my side and it's not related to this PR, so you are safe to merge 🚀