Electric-Coin-Company / zcash-android-wallet-sdk

Native Android SDK for Zcash
MIT License
5 stars 7 forks source link

Remove Grouping and Decimal MonetarySeparators check #1501

Closed HonzaR closed 3 weeks ago

HonzaR commented 3 weeks ago

Describe the issue

As reported by a user, we should not check the Monetary grouping and decimal separators on inequality, as that could lead to potential troubles.

Can you reliably reproduce the issue?

No, we can't.

Expected behaviour

When a device has a locale with the same grouping and decimal separators, we should not warn about it and leave such cases to clients to handle in their logic and UI.

Actual behavior + errors

The SDK check the separators using this code fragment:

require(grouping != decimal) { "Grouping and decimal separator cannot be the same character" }

Any extra information that might be useful in the debugging process.

For now, we only know that such a locale might occur in a real device. User reported that they have some German language with a European region.