search

Electric-Coin-Company / zcash-android-wallet-sdk

Native Android SDK for Zcash
MIT License
5 stars 10 forks source link

Verify Addresses without Synchronizer #342

Open ccjernigan opened 2 years ago

ccjernigan commented 2 years ago

What is your feature request? Consider a strongly typed API for wallet addresses, instead of strings.

In addition, consider a factory method that takes in a string, validates it as an address, and emits a valid strongly typed address object (or throws an exception if the address is invalid).

How would this feature help you? When developing the wallet UI, strings passed around are a weak type and validation of these strings is difficult to do.

Current validation APIs require access to the Synchronizer instance, which has become a bit of a God object and doesn't need to be passed around to most views when using Compose.

pacu commented 2 years ago

I Like this, we should carve out a consistent API that works and reads similarly on both platforms. And that maybe plays well with the FFI stuff

rafaelekol commented 12 months ago

@HonzaR Any option to validate Zcash address, without Synchronizer?

HonzaR commented 12 months ago

Hi @rafaelekol, There is no progress in this matter yet, but in the current reworking of our wallet, we'll probably need to touch this.