Electric-Coin-Company / zcash-android-wallet-sdk

Native Android SDK for Zcash
MIT License
5 stars 6 forks source link

Add ZIP 321 URI parser #397

Open ccjernigan opened 2 years ago

ccjernigan commented 2 years ago

Is your feature request related to a problem? Please describe.

In order to support zcash/secant-android-wallet#134 and zcash/secant-android-wallet#202, we need a parser for https://zips.z.cash/zip-0321

Describe the solution you'd like

A parser has been implemented in Rust, so ideally the SDK would expose a Kotlin API for the app to consume this.

Implementation tips

HonzaR commented 2 years ago

Hi @ccjernigan, have you decided on the naming of the new stateless/utility RustBacked classes yet? I'm in favor of utility naming, because I assume there will be more utility methods added later.

ccjernigan commented 2 years ago

I don't really have a strong opinion—if you think utility works then that seems like a reasonable place to start. This particular class will be internal to the SDK, so as a non-public API we can rename or refactor it as we learn more about how it will get used in practice.

HonzaR commented 2 years ago

Solution to this issue depends on updating lib.rs library in the Android SDK project. Waiting for it then. https://github.com/zcash/ZcashLightClientKit/issues/335