search

Electric-Coin-Company / zcash-android-wallet-sdk

Native Android SDK for Zcash
MIT License
5 stars 9 forks source link

Checkpoint format does not support post NU5 getTreeState() RPC JSON format #550

Closed pacu closed 2 years ago

pacu commented 2 years ago

Reference: https://github.com/nighthawk-apps/nighthawk-wallet-android/issues/118

Nighthawk apps released a version of their app with an incompatible format for checkpoint files because they used the direct output of getTreeState instead of replacing saplingTree with just tree.

This is not a problem of GRPC since protobufs care about ordinal position of the fields instead of name of the keys.

pacu commented 2 years ago

We've discussed the changes. We agreed on using versioning at least on Android since relying purely on JSON is better for possible multi-platform support