Closed tw0po1nt closed 1 year ago
I have two small comments otherwise this looks ok.
@Chlup @LukasKorba Since this is my first PR in this repo, I just have a couple questions.
@Chlup @LukasKorba Since this is my first PR in this repo, I just have a couple questions.
- Do you guys usually have the PR opener merge, or do you have another maintainer manage that?
- In the contributing docs, it mentions to keep the change log up to date, but it doesn't look like some of the other open PRs have updated that. Would you like me to update that prior to merging this?
Hi Matthew,
PR opener usually merges the PR after it's approved by some maintainer. Changelog is usually updated for the PRs that change public API. Which this does. Please update CHANGELOG.md
file accordingly.
Before merging the PR please make sure that all the targets can be compiled. You can use All
scheme for that. And please be sure that tests work. Unfortunately CI currently doesn't run all the tests. Running the DarksideTests
can be little challenging. But we can help with that.
Have a nice day. Michal
I checked the tests and all work fine. Just please fix the compilation of the sample app and you should be good to go.
The
Initializer
struct now takes aLoggingPolicy
parameter, which enables the following options when initializing the SDK:default
- the SDK will default to using its own internal implementation of theLogger
protocol at thedebug
log level. You can also override the log level by passing your preferred log level in to the enum case.custom
- the user provides an object conforming to theLogger
protocol, allowing for complete customizability of the logging.noLogging
- the SDK will not log anythingCloses #1013
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer