Closed str4d closed 9 months ago
Rebased on current main
. I think this PR can be reviewed and merged (as the corresponding lightwalletd
PR has been), and then we can continue fixing the Darkside tests in subsequent PRs.
I pulled lightwalletd, used make
to build the latest server and ran all dark side test with this result:
I don't know if this is expected or not, I remember str4d to talk about fixes of fundamental issues but still, after thiese fixes the tests need to be iterated to pass...
Approving as I also think the purpose of this PR is fulfilled.
Depends on https://github.com/zcash/lightwalletd/pull/448.
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer