Electric-Coin-Company / zcash-swift-wallet-sdk

iOS light client Framework proof-of-concept
MIT License
37 stars 33 forks source link

Migrate to latest `darkside.proto` to help fix Darkside tests #1191

Closed str4d closed 9 months ago

str4d commented 9 months ago

Depends on https://github.com/zcash/lightwalletd/pull/448.

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

Reviewer

str4d commented 9 months ago

Rebased on current main. I think this PR can be reviewed and merged (as the corresponding lightwalletd PR has been), and then we can continue fixing the Darkside tests in subsequent PRs.

LukasKorba commented 9 months ago

I pulled lightwalletd, used make to build the latest server and ran all dark side test with this result:

Screenshot 2023-08-24 at 14 09 15

I don't know if this is expected or not, I remember str4d to talk about fixes of fundamental issues but still, after thiese fixes the tests need to be iterated to pass...

LukasKorba commented 9 months ago

Approving as I also think the purpose of this PR is fulfilled.