Open pacu opened 4 months ago
There's a possible regression spotted by the func testDarkside() async throws
test.
According to the logs, the synchronizer syncs the blockchain until block 663200. then there's this error.
-[DarksideTests.DarksideSanityCheckTests testDarkside] : failed - failed with error: rustScanProgressOutOfRange("0/0")
I believe this could be a false-positive error.
closes #1341
Updates Proto files and compile new swift versions
Adds setSubTree darkside service adds subtrees into buildFakeChain() methods
Makes the Advanced ReOrg Tests work again. Some of them pass and others don't. The scope of this PR is make them stop failing because of an unimplemented service
As it can be appreciated in the screenshot the "sanity tests" pass. So darksidewalletd functionality has been restored
Fixing the christmas tree of checks is left for other PRs in the future.
This PR depends on: https://github.com/zcash/lightwalletd/pull/469 being merged
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer