Closed str4d closed 2 months ago
Force-pushed to address review comments.
Force-pushed to clean up the commits.
I tested all 5 APIs while working on adoption of this PR (e9177a28f73d19f81849108e9b4978a10a08a582) in Zashi. I can confirm
Before we merge this, I'm going to add a helper method to Proposal
to expose the number of steps, so that callers can anticipate how many events they will get from the async stream returned from createProposedTransactions
.
Force-pushed to remove the 2.0.11 changelog bump, as @LukasKorba will make a few other release updates before the actual release commit.
Closes Electric-Coin-Company/zcash-swift-wallet-sdk#1343.
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer