Electric-Coin-Company / zcash-swift-wallet-sdk

iOS light client Framework proof-of-concept
MIT License
37 stars 33 forks source link

Expose property nullProgress for ECC Reference Wallet #347

Closed pacu closed 2 years ago

pacu commented 2 years ago

BlockProgress struct was missing a public initializer for ECC Wallet's CombineSynchronizer to convert SyncStatus into CombineSynchronizer States.

there was an internal helper but it was not exposed. A static property was made public instead

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

Reviewer

geffenz commented 2 years ago

@adamstener can you give us an update on what is done and what isn't (and possibly check the boxes)? I'd like to close this but don't see enough documentation.

adamstener commented 2 years ago

I'm not familiar with what this is

adamstener commented 2 years ago

Looks like ci is failing?