Electric-Coin-Company / zcash-swift-wallet-sdk

iOS light client Framework proof-of-concept
MIT License
37 stars 33 forks source link

Remove account field from `UnifiedFullViewingKey` #522

Open nuttycom opened 1 year ago

nuttycom commented 1 year ago

Why is the UFVK carrying around its account ID? This might be okay, but it will cause problems if we want a wallet to be able to use UFVKs that do not correspond to the wallet's accounts; this will make it harder to implement the feature that I want where a wallet can import a UFVK to obtain watch-only functionality for a cold wallet. If this could be handled separately it would be good to make that breaking change to the API now, while we're making other breaking API changes.

_Originally posted by @nuttycom in https://github.com/zcash/ZcashLightClientKit/pull/491#discussion_r963742711_