Electric-Coin-Company / zcash-swift-wallet-sdk

iOS light client Framework proof-of-concept
MIT License
36 stars 34 forks source link

Add Swift GRPC Plugin To ZcashLightClientKit #725

Closed pacu closed 1 year ago

pacu commented 1 year ago

We want the generated code from the proto files to be always in sync with current Swift-GRPC version

let's add the Swift-GRPC plugin to the SDK so that we can

reference: https://github.com/grpc/grpc-swift

Chlup commented 1 year ago

This can't be done in a way we expected. Any generating of proto files depends on protoc binary. And this binary isn't distributed together with Swift-GRPC plugin. So if we do this we will bother all the developers that use SDK to have protoc installed even though they don't need it. Let's don't do this. At least not now.