search

ElectricNightOwl / ArmSwinger

ArmSwinger is an artificial VR locomotion library developed on Unity 5.4. ArmSwinger allows you to use your arms to control your position in 3D space in a natural way with minimal disorientation.
http://electricnightowl.com/armswinger/
MIT License
101 stars 30 forks source link

Use Touchpad for move #41

Closed omerfaruk closed 7 years ago

omerfaruk commented 7 years ago

Use touchpad axis for activate armswinger (top,bottom etc.)

kjack9 commented 7 years ago

Much better, thanks! Will review soon.

omerfaruk commented 7 years ago

i use 0.5f and -0.5f for buttons.I think someone who knows good math can make calculations on circle and make better version.In my version there some dead spot on touchpad.

axisData.x < 0.5f && axisData.x > -0.5f

kjack9 commented 7 years ago

After careful consideration, I'm going to close this PR without merging it. While I appreciate the contribution, and it does work fine, I really feel like touchpad movement should be implemented separate from ArmSwinger. I already half think that ArmSwing should be split into movement and player collisions scripts, and adding touchpad movement just adds crowding to an already crowded script. Something like VRTK or NewtonVR is a much better place for the additional functionality.

Thanks again for contributing.

omerfaruk commented 7 years ago

It just activate armswinger with touchpad button.I think this script need this.Because in our game we use grip button for reload and trigger for shoot.We have to use axis for walk.