search

Electroblob77 / Wizardry

Source code for Electroblob's Wizardry, a Minecraft mod about magic, exploration and adventure. Open-source so other aspiring wizards (a.k.a. programmers 😎) can see the real magic! ✨ Just want to download and play? Head over to the CurseForge page via the link below:
https://minecraft.curseforge.com/projects/electroblobs-wizardry
Other
203 stars 105 forks source link

Electrobob multiple Advancement Synchronisation messages for same player #475

Open Skinner1818 opened 4 years ago

Skinner1818 commented 4 years ago

Please read the guide for contributing before posting.

Minecraft version: 1.12.2
Wizardry version: 4.2.9 Environment: Hosted server via Apex minecraft with Spongeforge wrapper

Issue details: Electrobob will randomly start posting multiple messages in the console regarding Advancements. There is no pattern to this that I can see so far, it can be anything from 4 messages to over 20 messages at a time and there is no common trigger in the console that I can find. I have attached a screenshot of what I am seeing from the console for multiple players.

Other mods involved: Potentially Spongeforge? Console output Console output2

Electroblob77 commented 4 years ago

Maybe this is related to #283? I never did get to the bottom of that issue.

This message should be logged when a player logs in, whenever they get an advancement, and whenever they change their language or resource packs. Every time it happens, a packet gets sent, so if it's being spammed that's not good!

I'm not sure what's going on, I'll do some testing myself and see if I can reproduce this behaviour.

Skinner1818 commented 4 years ago

Thanks for looking into it. If it helps, I also ran some timings reports and Electrobobs was the highest mod for tick rate in the pack with Electroblob's Wizardry::Class_onLivingUpdateEvent contributing 2.6% out of over 200 mods. I've put in a screenshot for more reference. Electrobob

Electroblob77 commented 4 years ago

@Skinner1818 Thanks for that, it has now been reported as a separate issue #484. I'm assuming the two are unrelated, but I don't know.

jmiln commented 4 years ago

I'm seeing the same sort of thing while running a server with MC Eternal v1.3.7.1 image

I did add sponge and followed the config recommendations for the pack, but I don't think any of those involved changing configs for this mod

dgibso29 commented 4 years ago

Having the same issue with MC Eternal v1.3.7.1 image

Let me know how I can help debug this.