search

Electroblob77 / Wizardry

Source code for Electroblob's Wizardry, a Minecraft mod about magic, exploration and adventure. Open-source so other aspiring wizards (a.k.a. programmers 😎) can see the real magic! ✨ Just want to download and play? Head over to the CurseForge page via the link below:
https://minecraft.curseforge.com/projects/electroblobs-wizardry
Other
200 stars 107 forks source link

[Bug] Recharging armor in arcane workbench with shards restores too much mana. #816

Closed Gruefodder closed 2 years ago

Gruefodder commented 2 years ago

Is there an existing issue for this?

Observed behaviour

When recharging wizard armor at the arcane workbench, magic crystal shards give 100 mana -- the same as a full magic crystal.

Expected behaviour

When recharging wizard armor at the arcane workbench with magic crystal I expected to get 10 mana as this would be consistent with what they give for wands.

Steps to reproduce

  1. Start a game (I observed this both on a server and in single player)
  2. Get some wizard armor in need of recharging.
  3. Put armor in arcane workbench.
  4. Place crystal shard(s) in the appropriate slot and charge the armor. Using one shows the behavior the clearest.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

4.3.7

Minecraft version

1.12.2

Forge version

1.12.2 -14.23.5.2859

Other mods

I originally saw this in a mod-pack running version 4.3.4 of Electroblob's Wizardry mod. I made an instance of 1.12.2 with only the Wizardry mod installed and still saw this behavior. Seeing there was a later version, I updated to 4.3.7 and still saw the behavior.

One note: The pack I originally saw this behavior in included JEI. The JEI interface showed the crystal shards only giving 10 mana to wizard armors, as expected.

WinDanesz commented 2 years ago

Are you referring to the element neutral crystal shards or the elemental shards added by Ancient Spellcraft?

WinDanesz commented 2 years ago

After checking the source, I came to the conclusion that this must have been about some EbWiz addon crystals. Next time, refer to the mod's issue tracker which provides the item.