Electroblob77 / Wizardry

Source code for Electroblob's Wizardry, a Minecraft mod about magic, exploration and adventure. Open-source so other aspiring wizards (a.k.a. programmers 😎) can see the real magic! ✨ Just want to download and play? Head over to the CurseForge page via the link below:
https://minecraft.curseforge.com/projects/electroblobs-wizardry
Other
200 stars 107 forks source link

[Bug] Tree textures are changed/deleted (with dynamic trees) #838

Open KurotamaTakauji opened 1 year ago

KurotamaTakauji commented 1 year ago

Is there an existing issue for this?

Observed behaviour

Tree branch textures are changed/missing. Image: https://imgur.com/a/f1uR3kX

Error log on startup:

...
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]: +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]: The following texture errors were found.
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]: ==================================================
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:   DOMAIN minecraft
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]: --------------------------------------------------
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:   domain minecraft is missing 1 texture
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:     domain minecraft has 3 locations:
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:       unknown resourcepack type net.minecraft.client.resources.DefaultResourcePack : Default
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:       mod ebwizardry resources at C:\Users\sbeni\AppData\Roaming\.minecraft\mods\ElectroblobsWizardry-4.3.9.jar
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:       resource pack at path C:\Users\sbeni\AppData\Roaming\.minecraft\resourcepacks\Enhanced+Audio+Modified.zip
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]: -------------------------
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:     The missing resources for domain minecraft are:
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:       textures/blocks/blocks/leaves_oak.png
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]: -------------------------
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]:     No other errors exist for domain minecraft
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]: ==================================================
[13:21:55] [Client thread/ERROR] [FML.TEXTURE_ERRORS]: +=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=
...

The behaviour is the same with or without any resource packs. Full debug.log: https://gist.github.com/KurotamaTakauji/b6ed8eda4c4646b9642044f64ee55522

I also tried changing the mod configs but it did not change anything: ebwizardry.cfg:

...
# List of registry names of blocks which can be overwritten by wizardry's structure generators, affecting both fast and fancy structure generation. Most tree blocks and other foliage should work automatically, but those that don't can be added manually here. Block names are not case sensitive. For mod blocks, prefix with the mod ID (e.g. dynamictrees:oakbranch).
    S:treeBlocks <
     >
...

My assumption: EBWizardry world generation somehow deletes/changes tree branch textures.

Expected behaviour

Tree banch textures work fine. If the game textures get refreshed/overwritten after startup the bug does not happen again. (e.g. load a resourcepack, F3+T for reloading resources). Image: https://imgur.com/a/A9GvCf2

Steps to reproduce

  1. Start the game with the required mods
  2. Join any games(multiplayer/singleplayer)
  3. Look at any trees

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

4.3.9

Minecraft version

1.12.2

Forge version

1.12.2 - 14.23.5.2859

Other mods

Baubles-1.12-1.5.2 DynamicTrees-1.12.2-0.9.4 ElectroblobsWizardry-4.3.9 furniture-5.3.1-1.12.2(Only for debug, same happens without this one) jei_1.12.2-4.16.1.1000

WinDanesz commented 1 year ago

Try redownloading both mods, from curseforge ofc