Electroblob77 / Wizardry

Source code for Electroblob's Wizardry, a Minecraft mod about magic, exploration and adventure. Open-source so other aspiring wizards (a.k.a. programmers 😎) can see the real magic! ✨ Just want to download and play? Head over to the CurseForge page via the link below:
https://minecraft.curseforge.com/projects/electroblobs-wizardry
Other
201 stars 106 forks source link

Spell Cast Command does not implement finishCasting method #858

Open ipdnaeip opened 1 year ago

ipdnaeip commented 1 year ago

Is there an existing issue for this?

Observed behaviour

When casting a continuous spell using the command system, if a spell has an effect that is supposed to go off after it is over, it will not activate.

This is not as much a bug as a missing feature as it is not implemented in the spell cast command code.

Expected behaviour

Spells should activate their finishCasting effect once the spell is finished casting

Steps to reproduce

Only grapple implements this method in the base mod and it does not have a very noticeable effect. In the Wizardry Next Generation addon, it affects the antigravity spell in that the part in which it applies levitation never activates.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Singleplayer

Mod version

4.3.7

Minecraft version

1.12.2

Forge version

1.12.2 14.23.5.2859

Other mods

Wizardry Next Generation