Consider moving all code into a top-level package

[mhsmith]

Electrum has now done this. As per the current setup.py, I assume we'd want our package to be called electroncash rather than electrum, otherwise it would be impossible to install both programs in the same environment. This will unfortunately make merges from Electrum harder than they were before, but no harder than they are right now since Electrum made this change.

Advantages:

• Using the same directory names in the source code and at runtime is simpler, and is the normal Python practice.
• The workarounds for the mismatching names can be removed from each of the GUIs, and will be unnecessary in the new Android app.
• It would make it easier to run the unit tests, as discussed in #723. Tests which are easier to run are more likely to be kept up to date. (The other test issue in that PR had been broken for over a month, so evidently nobody had run the tests in that time.)

Disadvantages:

• All open branches and pull requests will have to be rebased.
• The workarounds for the mismatching names must be removed from each of the GUIs.

[cculianu]

I admit it's rather bizarre the way the dirs are mapped to module names right now.

I fear this may create a subtle source of bugs unless we are careful with text searches (I guess it shouldn't be too bad.. but still).

So no more "electroncash_gui" namespace? Everything is filed under "electroncash" now? (Eg electroncash.gui)??

This external plugins will also be affected... :/

Are you sure you want to open this can of worms? :P

(Clearly I'm of the pragmatic mindset: if it ain't broke, don't fix it.)

PS: Right now might not be a good time. There is a parallel fork of Electron Cash called "SLP" that aims to add tokens to Electron Cash. Perhaps wait until that's done?

[fyookball]

i'd rather avoid this if not necessary

[mhsmith]

Fair enough: it was mentioned on Slack a couple of days ago, so I thought it should be recorded somewhere more permanent. The workaround for Chaquopy had a small performance cost, but I've already solved that for another project so it shouldn't be a factor anymore.

Let's leave it open for another day or so in case anyone else wants to comment.

[kyuupichan]

I think this is a good idea. Electron Cash now warns it's using obsolete features with Python3.7 because of the current hack

[rt121212121]

Some things we need to address:

• The smoothest workflow for replacing cherry-pick, as we can no longer use it to cleanly map commits.
• How to retain git history, note that electrum did something wrong, and the history of files was lost in github. It appears to have detected the renames, but the history is cut off at the point of the move.

For example: https://github.com/spesmilo/electrum/commits/master/electrum/network.py

On Fri, Jul 20, 2018 at 1:01 PM Neil notifications@github.com wrote:

I think this is a good idea. Electron Cash now warns it's using obsolete features with Python3.7 because of the current hack

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fyookball/electrum/issues/807#issuecomment-406457884, or mute the thread https://github.com/notifications/unsubscribe-auth/AfFyJrn-bgnS-A2-vb4byqauHSI0Ey3nks5uISv3gaJpZM4VWGKW .

[rt121212121]

Here's the electrum commit, which would be a good point of reference to ensure nothing is missed.

https://github.com/spesmilo/electrum/commit/097ac144d976eb46dff809e1809783dc78ab6d8b#diff-554a6e574ded9f74c5821ea55e34d488

[cculianu]

Ok, this wasn't quote handled fully by #2020 but partially. The reason why it wasn't done completely is that it's a lot smaller a diff to do it the way it was done in #2020. Ideally we'd have electroncas/gui and electroncash/plugins but that would break existing external plugins -- and maybe that would be a major revision thing.

[mhsmith]

Yeah, I don't think that would be worth the trouble.