search

Electron100 / butane

An ORM for Rust with a focus on simplicity and on writing Rust, not SQL
Apache License 2.0
94 stars 13 forks source link

clippy complains of redundant deref #184

Open jayvdb opened 8 months ago

jayvdb commented 8 months ago 
warning: call to `.deref()` on a reference in this situation does nothing
   --> /home/jayvdb/rust/butane/butane_core/src/db/sqlite.rs:490:52
    |
490 |             return Err(Error::IncompatibleCustomT(v.deref().clone(), BACKEND_NAME))
    |                                                    ^^^^^^^^ help: remove this redundant call
    |
    = note: the type `SqlTypeCustom` does not implement `Deref`, so calling `deref` on `&SqlTypeCustom` copies the reference, which does not do anything and can be removed
    = note: `#[warn(noop_method_call)]` on by default

Not sure if we might want to implement Deref. Probably not.