ElectronNET / Electron.NET

:electron: Build cross platform desktop apps with ASP.NET Core (Razor Pages, MVC, Blazor).
https://gitter.im/ElectronNET/community
MIT License
7.28k stars 724 forks source link

Newtonsoft.Json nuget package fails on Electron.NET app #686

Closed domingoladron closed 2 years ago

domingoladron commented 2 years ago

It appears that if you run up a Blazor app inside Electron.NET and try to call anything using Newtownsoft.Json library (tried both 13.01 and 12.03), it will fail with the following error:

FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'. The system cannot find the file specified.

If you try this same thing when running the app as a web app (IIS, Docker, etc.) it works fine.

I've added a blob of simple JSON deserialisation using the Newtonsoft.JSON JsonConvert class to the Index.razor page to show the error when you run up the Electron.NET app.

//just calling Newtownsoft.Json class to fire the exception

 var fakeClassData = JsonConvert.DeserializeObject<FakeClass>(await File.ReadAllTextAsync(Path.Join(Environment.CurrentDirectory, "fakefile.json")));

I think this has to do with how Newtownsoft.JSON versions packages. While the package is labeled 13.0.1, internally, the package itself is versioned '13.0.0' and the app running in Electron.NET can't find it.

Steps to Reproduce:

  1. Including Newtonsoft.JSON to your web app as a nuget package

  2. Call some code from within the Newtonsoft.JSON package

  3. Start the app as a website. Everything will run fine image

  4. Start the app via electronize. It will bomb immediately upon hitting the Newtownsoft.JSON code image

domingoladron commented 2 years ago

I can confirm that if I ditch Newtonsoft.JSON (which, btw, appears to be used in the Electron.NET WebApp csproj as a dependency) and instead use System.Text.Json Serializer / Deserializer classes, everything works mint.

Here's a branch with the fixed code

https://github.com/domingoladron/LearnBlazor.ElectronNet/tree/bug/json-net-electron-net-fixed

So it is specifically to do with Newtonsoft.JSON.

Melethainiel commented 2 years ago

It seems not to be only newtonsoft library. I got the same error with epplus. Last month it was working well.

domingoladron commented 2 years ago

What is the error message you're getting? What version are you now using? Under which version was it working?

domingoladron commented 2 years ago

Didn't intend to close that. Mobile app is tetchy.

ipax77 commented 2 years ago

I could not make my app build/publish successful with dotnet 6.0.4, the window does not open and it is stuck at

Electron Socket IO Port: 8000
Electron Socket started on port 8000 at 127.0.0.1
ASP.NET Core Port: 8001

I reverted to dotnet 6.0.3 and everything is working as usual.

Melethainiel commented 2 years ago

@domingoladron I got this error :

System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.IO.RecyclableMemoryStream, Version=2.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. Le fichier spécifié est introuvable.
File name: 'Microsoft.IO.RecyclableMemoryStream, Version=2.2.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'

I Tried with dotnet 6.0.102 to 6.0.202 and none are working

Melethainiel commented 2 years ago

The bug seems to be only on my computer as on Azure CI build, I don't get the exception.

ipax77 commented 2 years ago

Updating my NuGet packages to 6.0.5 solved my problems.

domingoladron commented 2 years ago

Updating my NuGet packages to 6.0.5 solved my problems.

I'll give that a try and close the bug if that sorts it. Cheers