search

ElectronicCats / CayenneLPP

Library for Arduino compatible with Cayenne Low Power Payload
http://electroniccats.com/
MIT License
106 stars 48 forks source link

decoder: TheThingsStack v3 support #19

Closed aparcar closed 3 years ago

aparcar commented 3 years ago

The new stack uses a slightly different format, could you please update/add another decoder.js script to support v3?

https://www.thethingsindustries.com/docs/integrations/payload-formatters/javascript/

sabas1080 commented 3 years ago

Hi @aparcar

Welcome contribution :D

amotl commented 3 years ago

Hi Paul and Sabas,

while I am not that much into the very details, I would like to point out that @thiasB just added https://github.com/hiveeyes/terkin-datalogger/commit/71699ded to the Terkin Datalogger.

In that manner, it might help to compare the implementations of [1] vs. [2], where [1] was already derived from this repository. By mentioning it, we want to take the chance to send a big thank you to @xoseperez, @ricaun and David, who we discovered to have originally committed to decoder.js.

Keep up the spirit and with kind regards, Andreas.

[1] https://github.com/hiveeyes/terkin-datalogger/blob/master/client/TTN/decoder_v2.js [2] https://github.com/hiveeyes/terkin-datalogger/blob/master/client/TTN/decoder_v3.js

amotl commented 3 years ago

Maybe you can also submit a pull request here, @thiasB?

thiasB commented 3 years ago

see https://github.com/ElectronicCats/CayenneLPP/pull/23

sabas1080 commented 3 years ago

Thanks @amotl and @thiasB