search

ElectronicCats / CayenneLPP

Library for Arduino compatible with Cayenne Low Power Payload
http://electroniccats.com/
MIT License
106 stars 48 forks source link

Adding new data types #5

Closed xoseperez closed 4 years ago

xoseperez commented 4 years ago

I've been working on a fork of this repo to add new data types for:

I have also added a unit test suite based on AUnit and a backwards compatible javascript decoder for TTN or NodeRED.

Everything is in the forked repo: https://github.com/xoseperez/CayenneLPP

The problem is that the code base is very different, including some files moved to subfolders to suit PlatformIO. The class itself is backwards compatible with this repo thou. My question is: should I keep it as a separate repo or would you be willing to accept a PR with the changes?

sabas1080 commented 4 years ago

Hi @xoseperez

Send your PR please, me and Wero we will review and add to this repository

Thanks for your work in espurna :D

xoseperez commented 4 years ago

Great. See PR #7 . It includes data types suggested by @gmag11 in PR #4, I hope he doesn't mind.

sabas1080 commented 4 years ago

Thanks @xoseperez merge

xoseperez commented 4 years ago

Great! Thank you.

jangrewe commented 3 years ago

I've started using this library and was pulling my hair why no data was showing up in Cayenne... turns out it doesn't like the data type 74 (from addVoltage()). Now i don't know the actual purpose of this library, but it should either be compatible with Cayenne, or mention somewhere which data types can't be used?

sabas1080 commented 3 years ago

Hi @jangrewe the README mention that detail, we support most of the types specified by OMA SpecWorks, formerly IPSO

Captura de Pantalla 2020-07-30 a la(s) 20 35 50
jangrewe commented 3 years ago

Well, for somebody just reading that it sounds like "we've added more stuff than anybody else. and we added a decoder". May i suggest adding something explicit like "These additional data types are not supported by myDevices Cayenne."? 🙂

xoseperez commented 3 years ago

You can also ping the people at Cayenne and ask them to add these data types to their product :smile:

sabas1080 commented 3 years ago

@jangrewe I have added the text 😀