ElectronicCats / ElectronicCats-PN7150

Arduino library for I2C access to the PN7150 RFID/Near Field Communication chip
MIT License
33 stars 15 forks source link

NxpNci_TVDD_CONF_2ndGen doesn't appear to reflect User Manual #19

Closed JWizlo closed 3 years ago

JWizlo commented 3 years ago

Hello, looking at the User Manual it says Byte 2 of PCM_CFG should be 0x00 for CFG1 and 0x01 for CFG2.

I see in this code 0x066400 is written but I'm curious if it should instead be 0x066401.

The data in question is stored in NxpNci_TVDD_CONF[] in Electroniccats_PN7150.cpp line 716.

I can't test this myself at the moment so I wanted to reach out and see if this discrepancy was known.

salmg commented 3 years ago

at this point we are testing the nxp prototype with this configuration which we ported from linux driver, and it seems that it is working properly; but we will continue testing to see any discrepancies in the hardware side, thanks

JWizlo commented 3 years ago

Okay. I was just curious if you had another datasheet that described the reserved bitfields that are edited in this code. But if the data came from the driver then that is probably the end of that line of inquiry. Thanks!