search

ElectronicControlsDesign / LoginDialog

0 stars 0 forks source link

Edit Field Overwrites Boundary #3

Open mitch-besser opened 7 years ago

mitch-besser commented 7 years ago

Typing a large number of characters into the Password edit field draws outside the bounding area.

mitch-besser commented 7 years ago

image

@JosephAlfonso Here's a picture of the editfield overwrite.

mitch-besser commented 7 years ago

@dbaltimore Any progress fixing this? Please make sure you notify @JosephAlfonso or me if you make progress or decide it can't be fixed.

dbaltimore commented 7 years ago

Re: [ElectronicControlsDesign/LoginDialog] Edit Field Overwrites Boundary (#3)

Hi Mitch,

I fixed everything yesterday and posted it to GIT then.  It works perfectly here.

David

Thursday, January 5, 2017, 12:15:24 PM, you wrote:

@dbaltimore Any progress fixing this? Please make sure you notify @JosephAlfonso or me if you make progress or decide it can't be fixed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

-- Best regards, David                            mailto:dbaltimore@BaltimoreLabs.com

            This email has been checked for viruses by Avast antivirus software.
            www.avast.com
mitch-besser commented 7 years ago

Should I assume you were on Joseph’s branch because I looked and didn’t see any changes on the master branch. FYI, you really shouldn’t be using Joseph’s branch. That’s his to do what he likes hence the name. You would be welcome to create your own branches.

Mitch Besser Senior Software Engineer | ECD

Excellence in Measurement Solutions Worldwide Phone: +1 503-659-6100 x262 Fax: +1 503-659-4422

[ECDLogo(2015)_100x100]

From: dbaltimore [mailto:notifications@github.com] Sent: Thursday, January 05, 2017 9:20 AM To: ElectronicControlsDesign/LoginDialog Cc: Mitch Besser; Author Subject: Re: [ElectronicControlsDesign/LoginDialog] Edit Field Overwrites Boundary (#3)

Re: [ElectronicControlsDesign/LoginDialog] Edit Field Overwrites Boundary (#3)

Hi Mitch,

I fixed everything yesterday and posted it to GIT then. It works perfectly here.

David

Thursday, January 5, 2017, 12:15:24 PM, you wrote:

@dbaltimore Any progress fixing this? Please make sure you notify @JosephAlfonso or me if you make progress or decide it can't be fixed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

-- Best regards, David mailto:dbaltimore@BaltimoreLabs.com

This email has been checked for viruses by Avast antivirus software. www.avast.com

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ElectronicControlsDesign/LoginDialog/issues/3#issuecomment-270701760, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQBhIHxSRa8JdbD4qoJQkZ1jIa-VlGkDks5rPSYjgaJpZM4LXCjp.

dbaltimore commented 7 years ago

Re: [ElectronicControlsDesign/LoginDialog] Edit Field Overwrites Boundary (#3)

No,  I am posting to https://github.com/ElectronicControlsDesign/LoginDialog/ I'm using  GITHUB Desktop but I think it's buggy because the c++ code I changed didn't post but the header did.

I am going to switch to GIT Gui.  The BASH version is not the same as in Linux for command line instructions.

I'll email you and Joseph when GIT is actually squared up with my local code.

Thursday, January 5, 2017, 12:25:51 PM, you wrote:

Should I assume you were on Joseph’s branch because I looked and didn’t see any changes on the master branch. FYI, you really shouldn’t be using Joseph’s branch. That’s his to do what he likes hence the name. You would be welcome to create your own branches.

Mitch Besser Senior Software Engineer | ECD

Excellence in Measurement Solutions Worldwide Phone: +1 503-659-6100 x262 Fax: +1 503-659-4422

[ECDLogo(2015)_100x100]

From: dbaltimore [mailto:notifications@github.com] Sent: Thursday, January 05, 2017 9:20 AM To: ElectronicControlsDesign/LoginDialog Cc: Mitch Besser; Author Subject: Re: [ElectronicControlsDesign/LoginDialog] Edit Field Overwrites Boundary (#3)

Re: [ElectronicControlsDesign/LoginDialog] Edit Field Overwrites Boundary (#3)

Hi Mitch,

I fixed everything yesterday and posted it to GIT then. It works perfectly here.

David

Thursday, January 5, 2017, 12:15:24 PM, you wrote:

@dbaltimore Any progress fixing this? Please make sure you notify @JosephAlfonso or me if you make progress or decide it can't be fixed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

-- Best regards, David mailto:dbaltimore@BaltimoreLabs.com

This email has been checked for viruses by Avast antivirus software. www.avast.com

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ElectronicControlsDesign/LoginDialog/issues/3#issuecomment-270701760, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQBhIHxSRa8JdbD4qoJQkZ1jIa-VlGkDks5rPSYjgaJpZM4LXCjp. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

-- Best regards, David                            mailto:dbaltimore@BaltimoreLabs.com

            This email has been checked for viruses by Avast antivirus software.
            www.avast.com
dbaltimore commented 7 years ago

Just fixed this. The textinput control is an edit region that can word wrap. There is a property, maximumLength that needed to be set is all.

Sorry, I didn't see your explicit comment originally. I thought that the dots were overrunning on entry and not a long entry,

mitch-besser commented 7 years ago

@dbaltimore I assume the maximumLength means the user can't type over that number of characters? If so, we'll need a different solution. @JosephAlfonso had a solution using clipping. Can you look at that as an option?