ElectronicControlsDesign / LoginDialog

0 stars 0 forks source link

Labels not right justified #4

Closed mitch-besser closed 7 years ago

mitch-besser commented 7 years ago

The labels (Username and Password) must be right justified, not left justified.

dbaltimore commented 7 years ago

I did add this code to the labels, but it moved the text far to the left. Not sure why yet Still working on it. horizontalAlignment: Text.AlignRight

mitch-besser commented 7 years ago

@dbaltimore not seeing your changes on github. I'm not seeing any code changes from you at all. Either I'm missing something or you are not pushing. Can you verify your push is working?

dbaltimore commented 7 years ago

Re: [ElectronicControlsDesign/LoginDialog] Labels not right justified (#4)

I am working in Joseph's branch as I was seeing no changes in the Master branch/

-- Best regards, David                            mailto:dbaltimore@BaltimoreLabs.com

            This email has been checked for viruses by Avast antivirus software.
            www.avast.com
JosephAlfonso commented 7 years ago

@dbaltimore: Please work on the master branch.

I have added horizontalAlignment: Text.AlignRight and it works. However, when we do translate the labels via the Test Translate button. This happens...

capture

dbaltimore commented 7 years ago

When I started using your repo, I saw empty framework code but Joseph had your current code.

I'll recheck the master and get the code.

I had the danger problem with right justifying the labels. It may be an interaction in the grid. Containers in qml tread to have a mind of their own. I'm researching it.

On December 29, 2016 3:27:48 PM EST, JosephAlfonso notifications@github.com wrote:

@dbaltimore: Please work on the master branch.

I have added horizontalAlignment: Text.AlignRight and it works. However, when we do translate the labels via the Test Translate button. This happens...

capture

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/ElectronicControlsDesign/LoginDialog/issues/4#issuecomment-269688545

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

JosephAlfonso commented 7 years ago

Great job!