search

ElectronicObserverEN / ElectronicObserver

Electronic Observer is a game viewer for Kantai Collection.
Other
81 stars 19 forks source link

Upgrade tree testability refactor #412

Closed myangelkamikaze closed 10 months ago

myangelkamikaze commented 10 months ago

Plan should never be null in UpgradeTreeUpgradePlanViewModel right? Doesn't look like it can from code, at least. I also deleted UpgradeTreeViewNodeState since it doesn't seem to be used. That information should technically already be available from the different viewmodels implementing IEquipmentPlanItemViewModel already too, I think. Or did you need that enum for anything else?

Also, I'm not sure if I should be chaining tests like this, feels dirty.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication