Avalonia ship groups improvements 2

ElectronicObserverEN / ElectronicObserver

Electronic Observer is a game viewer for Kantai Collection.

Other

83 stars 20 forks source link

Closed myangelkamikaze closed 4 months ago

myangelkamikaze commented 4 months ago

Continuing from #470

[ ] Get rid of WinForms dialogs
- [x] Text input dialog
- [ ] Text select dialog
- [ ] Ship group filter dialog
- [ ] Ship group CSV export dialog
[x] Add data grid settings
- [x] Header/row height
[x] Background colors

Notes:

new dialogs need a window reference, so they have to be done in WPF instead of Avalonia for now, but the dialog library supports both WPF and Avalonia, so a migration later should be fairly simple

Jebzou commented 4 months ago

Weird behavior after closing a dialog

myangelkamikaze commented 4 months ago

Weird behavior after closing a dialog

Should be fixed.

Behavior is not the same as old groups, is that intended ?

It wasn't really intended, it was just less work to do it this way. But I added the logic to match the old group behavior now.

sonarcloud[bot] commented 4 months ago