search

ElectronicObserverEN / ElectronicObserver

Electronic Observer is a game viewer for Kantai Collection.
Other
84 stars 20 forks source link

Add extension support #511

Closed Jebzou closed 3 days ago

Jebzou commented 1 week ago

Had to handle Cefsharp and Webview2 differently :

Cefsharp : Cefsharp had support for extensions but was buggy. In newer version, they dropped extension support. But you can manually add extension with Chrome's built-in extension manager. So in extra browser, I added a button that opens chrome's extension page.

image

Webview2 : Webview2 supports extensions programmatically, but the user can't manage his extensions. I added a button that opens a simple view that behaves like chrome's extension page in extra browser.

image

myangelkamikaze commented 1 week ago

I think we need to handle the https redirect for higher CefSharp versions. I tried to raise the version before but people got stuck with a white screen. I forgot how to reproduce it reliably. https://discord.com/channels/535244652505202689/936673384689975338/1272901460513919007

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE