search

Electronicks / JoyShockMapper

A tool for PC gamers to play games with DualShock 4s, JoyCons, and Pro Controllers. Gyro aiming, flick stick.
Other
332 stars 20 forks source link

[Bug] Motion stick deadzone broken as of v3.5.0 #102

Open kurushimee opened 10 months ago

kurushimee commented 10 months ago

The release v3.5.0 has broken the MOTION_DEADZONE_INNER and MOTION_DEADZONE_OUTER settings. Default values of 15 degrees inner deadzone and 135 degrees outer don't apply, and attempting to change the value manually doesn't affect the motion stick. It functions as if both deadzone settings are set to zero, so every input is accounted and the range of motion is 180 degrees to both sides.

Works as expected in v3.4.0, the issue appeared only when updating to v3.5.0 (also ruled out any possible system failure as I've also tested it after reinstalling Windows lmao).

kurushimee commented 10 months ago

Same thing in v3.5.1

Electronicks commented 10 months ago

Thanks for the report. I'll look into it.

Electronicks commented 10 months ago

I tested the virtual controller on hardware tester web page and played around with the settings and could observer everything working as expected in v3.5.1. VIRTUAL_CONTROLLER = XBOX MOTION_STICK_MODE = RIGHT_STICK MOTION_DEADZONE_INNER = 45 # in degrees MOTION_DEADZONE_OUTER = 90 #in degrees, 180 being maxMOTION_DEADZONE_INNER = 45 # in degrees MOTION_DEADZONE_OUTER = 90 #in degrees, 180 being max

The stick outputs 0-100 between angles 45 to 90. Can you confirm?

kurushimee commented 10 months ago

I see the confusion now, the issue isn't present when setting MOTION_STICK_MODE to LEFT_STICK or RIGHT_STICK, but it's there when you set it to LEFT_STEER_X for example, which is what I was using.