search

Electronicks / JoyShockMapper

A tool for PC gamers to play games with DualShock 4s, JoyCons, and Pro Controllers. Gyro aiming, flick stick.
Other
332 stars 20 forks source link

[Bug] Turbo modifier does not work simulated virtual controller buttons #99

Closed santarl closed 9 months ago

santarl commented 11 months ago

Hi, I found a bug with turbo modifier on virtual controller

VIRTUAL_CONTROLLER = XBOX
S = X_A+

Expected Behaviour: X_A is pulsed Observed Behaviour: X_A is continuously held down

I've tried this with both DS4 and XBOX modes, it doesn't work in either of them.

Thanks

Electronicks commented 10 months ago

Fixed in v3.5

santarl commented 10 months ago

I am still facing the same issue on 3.5

Electronicks commented 10 months ago

I did some testing. The buttons are released for 40ms which is very short amount of time. Did you try in hand whether it works? Because vscview and the windows panel won't display it properly.

You can also use both turbo and toggle to have 50-50 press time. It will be visible then

santarl commented 10 months ago

Did you try in hand whether it works?

I tested it in game again and it doesn't seem to work on my end. Either it is pulsing way too fast for the game to detect or it is simply not pulsing at all. But Turbo works with steaminput so I don't think it is the game.

You can also use both turbo and toggle to have 50-50 press time. It will be visible then

I don't understand this, could you show those commands?

I also tried modifying TURBO_PERIOD = 1000 to see if that changes anything. but that only affects the output in the commandline and doesn't seem to affect actual turbo period for virtual controller.

I would like to suggest the option to set the time for pulse rate and pulse duration manually.

santarl commented 9 months ago

fixed as of c5fcf306ce5b6e675b2e165856531ed1d5626732