search

Electrostatics / APBS_Sphinx

APBS Rewrite
http://www.poissonboltzmann.org
1 stars 3 forks source link

Update Plugins to accept lists of data #25

Closed keith923 closed 8 years ago

keith923 commented 8 years ago

Some of the plugins (at least Geoflow, and likely others) are written with the assumption that they are orly receiving one datum at a time from the Data Bus. This is incorrect now, and needs fixing.

keith923 commented 8 years ago

Maria, this would be perfect for you. Let me know if you need clarification or guidance, and we'll talk.

mtartakovsky commented 8 years ago

@keith923 Does this mean one file at a time, or one line at a time?

keith923 commented 8 years ago

I'm not sure what you mean wrt files.

Take a look at line 84 in the ParseXYZR plugin, and you can see where it's using a for loop to iterate over an array of "stuff" that's passed to the plugin. This is the right way. It's receiving multiple data in a single call. The Geoflow plugin does not do this. It instead assumes that it's getting all of the data that it needs in one shot.

mtartakovsky commented 8 years ago

@keith923 I made a small change to the Geoflow plugin

keith923 commented 8 years ago

Done as well. Fantastic!