Get pybind11 to work in Appveyor and Github Actions

Electrostatics / apbs

Software for biomolecular electrostatics and solvation calculations

http://www.poissonboltzmann.org/

Other

94 stars 26 forks source link

Get pybind11 to work in Appveyor and Github Actions #75

Open intendo opened 4 years ago

intendo commented 4 years ago

The Appveyor file (https://github.com/Electrostatics/apbs/blob/master/appveyor.yml) and Github Actions file (https://github.com/Electrostatics/apbs/blob/master/.github/workflows/build.yml) need to be fixed so that pybind11 doesn't crash the builds.

ashermancinelli commented 4 years ago

@intendo I believe I fixed this (it's passing the CI builds), but can I get your confirmation before closing?

intendo commented 4 years ago

The Github Actions are working but Appveyor is still failing.

ashermancinelli commented 4 years ago

Appveyor appears to be passing for master now - is this resolved?

intendo commented 4 years ago

The only reason Appveyor is working is that it has Python and Shared Libraries turned off. If we want to have Python via pybind11, we would want to turn Python and Shared Libraries on in Appveyor builds.