search

Electrynth / legion-HQ

http://legion-hq.com
5 stars 1 forks source link

Change to an externally managed JSON constants file #17

Open lukeraymonddowning opened 5 years ago

lukeraymonddowning commented 5 years ago

What are your thoughts on this @nicholas-charles-brown: https://github.com/hquplink/swlegion/blob/master/lib/catalog.json

How simple do you think a refactor would be? Just thought it would take some legwork out of changes for you.

Electrynth commented 5 years ago

As of now I'm already working on refactoring the card data (actually refactoring everything at this point) into a database and the card images into Amazon s3 buckets. Additionally, I'm not a huge fan of the structure that catalog is in. I would prefer the names to be in pascal case, I do not like the way the catalog organizes the requirements for upgrades, not a fan of how some types have hyphens in the name (i.e. "type": "repulsor-vehicle"), and I would like to have control over what fields are in there. I also like the way setup the requirements for upgrades in my data.json file.

The original reason I did the 2 letter ID was because I thought I was gonna implement a feature that allowed users who didn't sign in the ability to share lists and I was going to use the letter IDs in the URL link. I ended up not doing this for other reasons but because I did it briefly (cuz I'm dumb) some lists in the database were saved with the double letter IDs.