ElektraInitiative / PermaplanT

https://www.permaplant.net
BSD 3-Clause "New" or "Revised" License
16 stars 13 forks source link

area of plants left-overs #1154

Closed markus2330 closed 9 months ago

markus2330 commented 10 months ago

Tasks

not so important:

Use case

area of plants

Related Pull request

1149

1160

Bushuo commented 10 months ago

@markus2330 there is another branch that I am working on, that fixes a couple of this issues. I will push it today.

markus2330 commented 10 months ago

Thx! There is no hurry though, tomorrow I am off.

markus2330 commented 10 months ago

We added:

Bushuo commented 10 months ago

@markus2330 I updated the PR. It is not ready yet, as I want to refactor at least the transformer out of the other stores and components. There is a lot of places where it is used and I want to define a uniform interface for it. My idea was, it is responsible for selections and transformations of konva nodes, a low level abstraction.

Bushuo commented 10 months ago

@markus2330 e2e tests are failing. I will fix them later, I hope you can review anyway.

markus2330 commented 10 months ago

Great job, we like it. But one new bug was introduced: amount indicator is not next to cursor (I added the item above). It seems to be related to zoom level.

So only 3 left-overs now! :rocket:

Btw. Do you get my emails? :ghost:

Bushuo commented 10 months ago

@markus2330 I am glad you like it. I fixed the cursor bug.

Btw. Do you get my emails? 👻

Sorry. I have not checked my TU account recently. I read it now and will answer shortly, with a new email address that I regularly check.

My TU mail is about to expire as well.