search

ElektraInitiative / PermaplanT

https://www.permaplant.net
BSD 3-Clause "New" or "Revised" License
16 stars 13 forks source link

use stage listeners #1155

Open markus2330 opened 10 months ago

markus2330 commented 10 months ago

@badnames Can you please also explain, why a stage listeners functionality was needed? https://github.com/ElektraInitiative/PermaplanT/blob/9f142c507d329f56aa77d505a188463ad4e65725/frontend/src/features/map_planning/components/BaseStage.tsx#L34 Currently it seems a bit convoluted this way. If you look at the plant layer https://github.com/ElektraInitiative/PermaplanT/blob/9f142c507d329f56aa77d505a188463ad4e65725/frontend/src/features/map_planning/layers/plant/PlantsLayer.tsx#L215 there is a backed-in functionality to listen to native Stage events. Maybe I am missing something?

Originally posted by @Bushuo in https://github.com/ElektraInitiative/PermaplanT/issues/1152#issuecomment-1881760174

markus2330 commented 10 months ago

Maybe I am missing something?

No, you are right :+1: It should be changed.

badnames commented 8 months ago

This was already removed in some branch, although it has not found its way into master yet.

markus2330 commented 8 months ago

Isn't it in #1135?