Feature/967 timeline backend

horenso commented 10 months ago

Basics

[x] The PR is rebased with current master
[x] I added a line to changelog.md
[x] Details of what I changed are in the commit messages
[x] References to issues, e.g. close #X, are in the commit messages and changelog
[x] The buildserver is happy

Checklist

[ ] I fully described what my PR does in the documentation
[ ] I fixed all affected documentation
[ ] I fixed the introduction tour
[ ] I wrote migrations in a way that they are compatible with already present data
[ ] I fixed all affected decisions
[ ] I added automated tests or a manual test protocol
[ ] I added code comments, logging, and assertions as appropriate
[ ] I translated all strings visible to the user
[ ] I mentioned every code or binary not directly written or done by me in reuse syntax
[ ] I created left-over issues for things that are still to be done
[ ] Code is conforming to our Architecture
[ ] Code is conforming to our Guidelines
[ ] Code is consistent to our Design Decisions
[ ] Exceptions to any guidelines are documented

First Time Checklist

[x] I have installed and I am using pre-commit hooks
[ ] I am using Tailwind CSS Linting

Review

[x] I've tested the code
[x] I've read through the whole code
[ ] I've read through the whole documentation
[ ] I've checked conformity to guidelines

horenso commented 9 months ago

@danielsteinkogler in this implementation we only get the years, months and dates that actually contained additions and removals. For instance even if start is 2021-MM-DD and end is 2024-MM-DD but the only activity was in 2022, you get

years: { "2022": {"addtions": 12, "removals": 34 } }
...

otherwise it's so much unnecessary data returned.

IMO we could also return an array with two indices like this:


years: { "2022": [12, 34] }
...

But let's do what ever is easier to work with in the frontend :)

markus2330 commented 9 months ago

addtions

I hope it is additions (typo) :wink:

otherwise it's so much unnecessary data returned.

I fully agree.

IMO we could also return an array with two indices like this:

This is probably already over-optimization. The JSON file gets compressed for transmission, doesn't it?

horenso commented 9 months ago

Earlier today @danielsteinkogler and I made phantastic progress, we could combine his super cool frontend with this timeline backend. I hope we can fix the tests fast and merge it into master. :rocket:

horenso commented 8 months ago

I added more tests and cleaned up this PR. I believe it can be merged. :)

danielsteinkogler commented 8 months ago

jenkins build please

markus2330 commented 8 months ago

Thank you, great job! :heart:

ElektraInitiative / PermaplanT