ElektraInitiative / PermaplanT

https://www.permaplant.net
BSD 3-Clause "New" or "Revised" License
16 stars 13 forks source link

Shading Layer Left-Over #1231

Open markus2330 opened 6 months ago

markus2330 commented 6 months ago

Tasks

Use case

shade layer

Related Pull request

1135

badnames commented 6 months ago

Cannot read Shading Type (white on white?)

Should be addressed in #1229

"couldn't load the image" if it is shown when heatmap is shown

Please elaborate.

undo on multi-select doesn't work (only for one element)

To my knowledge the same issue currently exists on the plant layer. The reason for this is that we don't have a mechanism for dispatching multiple actions as a group (such that they can be undone and redone as one unit). If multiple actions are required, they are currently dispatched in a simple for-loop.

Ideally, we should fix both issues in one PR.

Cannot move or resize shading areas (handle disabled?)

This has not yet been implemented for simplicity, but it would certainly be beneficial from a UX perspective.

markus2330 commented 6 months ago

To my knowledge the same issue currently exists on the plant layer.

It works and it is easy to try out.

The reason for this is that we don't have a mechanism for dispatching multiple actions as a group

Backend supports patch for arrays of plant actions and this should be added for the other endpoints, too (by the backend team).

This has not yet been implemented for simplicity, but it would certainly be beneficial from a UX perspective.

Hopefully this gets easier (without individual effort per layer) after frontend refactoring. We talk about this on Tuesday.