search

ElektraInitiative / PermaplanT

https://www.permaplant.net
BSD 3-Clause "New" or "Revised" License
16 stars 13 forks source link

text is cut on warnings in left toolbar #1277

Closed markus2330 closed 6 months ago

markus2330 commented 7 months ago

Describe the Bug

No response

Steps to Reproduce the Problem

select several plants, hover over warning symbol

Expected Result

That warning text is readable

Actual Result

image

PermaplanT version

master

Operating System

Linux

Browser

Firefox

Versions of other relevant software/extensions

No response

Additional info/logs

No response

andreicristian97 commented 7 months ago

Analysis of the issue: As there is no difference in z-index in the components, the order in which the components are rendered determines the "layering". It looks like the tooltip label gets rendered after the base layer of the map, but before the rest of the layers. (See screenshots from Edge's "3D View" Tool).

Simple solution: give a definite z-index value to the tooltip, to be rendered on top of the application.

Capture Capture2
markus2330 commented 7 months ago

Great analysis! Please also document which z-indexes normally should be used/are used for various parts of our application.

andreicristian97 commented 7 months ago

Currently used z-index values throughout the app, from lowest to highest (as explicitly set in code, or observed in the 3D View coming from external elements):

Based on this, some low value could be set for the Tooltip component, to be on top of the map but not interfere with the Modals or Navbar. To be clarified in what context the "BottomStatusPanel" is used, and if the tooltip could conflict with it - and if yes, decide which value should be higher

markus2330 commented 7 months ago

Great work! Please add a paragraph about this in doc/guidelines/frontend-ui-usability.md so that newly created modal forms etc. are somewhat consistent to current use of z-index (or if there are changes needed, please propose).